Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(guidepup): popover #3010

Merged
merged 16 commits into from
Aug 15, 2024
Merged

test(guidepup): popover #3010

merged 16 commits into from
Aug 15, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Aug 7, 2024

Proposed changes

Added guidepup test for popover component.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🍄🆙improvement New feature or request 🧪test Improvements/bugs for testing-framework labels Aug 7, 2024
@mfranzke mfranzke added this to the v0.4.0 milestone Aug 7, 2024
@mfranzke mfranzke self-assigned this Aug 7, 2024
@mfranzke mfranzke removed their assignment Aug 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/test-guidepup-popover

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Aug 7, 2024
@mfranzke mfranzke enabled auto-merge (squash) August 7, 2024 20:07
@github-actions github-actions bot added the 🏘components Changes inside components folder label Aug 14, 2024
nmerget and others added 2 commits August 15, 2024 07:49
@nmerget
chore: update snapshots
40ec3e0 
fix: issue with angular issue for popover trigger
@nmerget
Merge branch 'main' into test-guidepup-popover
3b071b4
@mfranzke mfranzke disabled auto-merge August 15, 2024 07:04
@nmerget nmerget merged commit 6f2482d into main Aug 15, 2024
61 checks passed
@nmerget nmerget deleted the test-guidepup-popover branch August 15, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases 🧪test Improvements/bugs for testing-framework
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget