Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(guidepup): simplification #3009

Merged
merged 5 commits into from
Aug 8, 2024
Merged

refactor(guidepup): simplification #3009

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d1b5df
refactor: simplification
mfranzke Aug 7, 2024
68be514
refactor: extracted array
mfranzke Aug 8, 2024
6c96f29
Merge branch 'main' into refactor-guidepup-test-strings
mfranzke Aug 8, 2024
70fc776
Merge branch 'main' into refactor-guidepup-test-strings
nmerget Aug 8, 2024
9d0cf97
Merge branch 'main' into refactor-guidepup-test-strings
mfranzke Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions showcases/screen-reader/default.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ const cleanSpeakInstructions = (phraseLog: string[]): string[] =>
.split('. ')
.filter(
(sPhrase) =>
!(
sPhrase.includes('You are currently') ||
sPhrase.includes('To enter') ||
sPhrase.includes('To exit') ||
sPhrase.includes('To click') ||
sPhrase.includes('To select') ||
sPhrase.includes('To interact') ||
sPhrase.includes('Press Control')
)
![
mfranzke marked this conversation as resolved.
Show resolved Hide resolved
'You are currently',
'To enter',
'To exit',
'To click',
'To select',
'To interact',
'Press Control'
].some((string) => sPhrase.includes(string))
)
.join('. ')
);
Expand Down
Loading