Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(guidepup): checkbox #3005

Merged
merged 36 commits into from
Sep 11, 2024
Merged

test(guidepup): checkbox #3005

merged 36 commits into from
Sep 11, 2024

Conversation

bruno-sch
Copy link
Collaborator

Proposed changes

adds guidepup test for checkbox

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@bruno-sch bruno-sch added the 🧪test Improvements/bugs for testing-framework label Aug 7, 2024
@bruno-sch bruno-sch enabled auto-merge August 7, 2024 13:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/test-guidepup-checkbox

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Aug 7, 2024
mfranzke
mfranzke previously approved these changes Aug 8, 2024
View reviewed changes
@mfranzke mfranzke changed the title test: adds guidepup test for checkbox test(guidepup): checkbox Aug 8, 2024
bruno-sch and others added 4 commits August 15, 2024 11:58
@bruno-sch
Merge branch 'main' into test-guidepup-checkbox
af5d8f6 
# Conflicts:
#	showcases/screen-reader/default.ts
@bruno-sch
chore: manually merged
49aeda5
@mfranzke
refactor: adding empty alternative text
3a10d0f 
this is even already getting announced by screen readers due to the standard required-attribute
@mfranzke
refactor: updated snapshot
18187cd
@github-actions github-actions bot added the 🏘components Changes inside components folder label Aug 15, 2024
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Aug 15, 2024
@github-actions github-actions bot removed the 🏗foundations Changes inside foundations folder label Aug 19, 2024
mfranzke
mfranzke previously approved these changes Sep 4, 2024
View reviewed changes
mfranzke
mfranzke previously approved these changes Sep 4, 2024
View reviewed changes
@nmerget nmerget self-requested a review September 11, 2024 07:25
@bruno-sch bruno-sch merged commit 5923892 into main Sep 11, 2024
61 checks passed
@bruno-sch bruno-sch deleted the test-guidepup-checkbox branch September 11, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke left review comments

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases 🧪test Improvements/bugs for testing-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruno-sch @mfranzke @nmerget