Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: plain html doesn't start any more #2971

Merged
merged 8 commits into from
Aug 5, 2024
Merged

fix: plain html doesn't start any more #2971

merged 8 commits into from
Aug 5, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Aug 3, 2024

Proposed changes

Resolves #2970

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🐛bug Something isn't working label Aug 3, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 RC milestone Aug 3, 2024
@mfranzke mfranzke self-assigned this Aug 3, 2024
@mfranzke mfranzke linked an issue Aug 3, 2024 that may be closed by this pull request
plain-html doesn't start any more #2970
Closed
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 3, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2970-plain-html-doesnt-start-any-more

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Aug 3, 2024
@github-actions github-actions bot removed the 📺showcases Changes to 1-n showcases label Aug 5, 2024
@mfranzke mfranzke changed the title 2970 plain html doesnt start any more fix: plain html doesn't start any more Aug 5, 2024
@mfranzke mfranzke marked this pull request as ready for review August 5, 2024 07:59
@mfranzke mfranzke removed their assignment Aug 5, 2024
@mfranzke mfranzke enabled auto-merge August 5, 2024 07:59
@mfranzke mfranzke merged commit 3c3b76c into main Aug 5, 2024
61 checks passed
@mfranzke mfranzke deleted the 2970-plain-html-doesnt-start-any-more branch August 5, 2024 08:17
@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-sch bruno-sch bruno-sch approved these changes

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🐛bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plain-html doesn't start any more
3 participants
@mfranzke @nmerget @bruno-sch