Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link on icons readme page in patternhub #2935

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

bruno-sch
Copy link
Collaborator

@bruno-sch bruno-sch commented Jul 30, 2024

Proposed changes

Link is corrected. Fixes #2930

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@bruno-sch bruno-sch enabled auto-merge July 30, 2024 09:01
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder labels Jul 30, 2024
Copy link
Contributor

@mfranzke
Copy link
Member

mfranzke commented Jul 30, 2024

@nmerget even though that @bruno-sch has a valid solution here, it might not be the best, as I would assume that we should link to an .md file instead of the resulting path, shouldn't we ?

@nmerget
Copy link
Member

nmerget commented Jul 30, 2024

If we want to enable the link in GitHub and Patternhub, we can't use relative paths. They have to be absolute :(

@mfranzke
Copy link
Member

mfranzke commented Jul 30, 2024

If we want to enable the link in GitHub and Patternhub, we can't use relative paths. They have to be absolute :(

por que? There seems to be some logic that let's those items appear as custom-icons path in the main navigation link. Why can't we use the same magic powder to even also rewrite any link to an .md file even for inline content?

@nmerget nmerget assigned mfranzke and unassigned nmerget Aug 5, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 RC milestone Aug 5, 2024
@mfranzke mfranzke removed their assignment Aug 5, 2024
@mfranzke mfranzke marked this pull request as draft September 22, 2024 11:09
auto-merge was automatically disabled September 22, 2024 11:09

Pull request was converted to draft

@mfranzke
Copy link
Member

@nmerget could you please have a look how we could set the links within markdown to target other Markdown files and still have those links adapted within the transformation of patternhub ?

@mfranzke mfranzke removed this from the Guidelines 3.0 RC milestone Oct 27, 2024
@nmerget nmerget marked this pull request as ready for review December 18, 2024 07:34
@nmerget nmerget enabled auto-merge (squash) December 18, 2024 07:39
@nmerget nmerget merged commit 506e40c into main Dec 19, 2024
72 checks passed
@nmerget nmerget deleted the fix-link-in-patternhubs-icons-readme-broken branch December 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more information link doesn't work
3 participants