-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken link on icons readme page in patternhub #2935
Conversation
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-link-in-patternhubs-icons-readme-broken |
@nmerget even though that @bruno-sch has a valid solution here, it might not be the best, as I would assume that we should link to an |
If we want to enable the link in GitHub and Patternhub, we can't use relative paths. They have to be absolute :( |
por que? There seems to be some logic that let's those items appear as |
@nmerget could you please have a look how we could set the links within markdown to target other Markdown files and still have those links adapted within the transformation of patternhub ? |
Proposed changes
Link is corrected. Fixes #2930
Types of changes
Further comments