fix: pipeline speed by skipping firefox test #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmerget
requested review from
mfranzke,
dkolba,
annsch and
bruno-sch
as code owners
|
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-pipeline-speed |
mfranzke
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Loading the complete playwright page in firefox takes very long. This leads to tests (accessibility-checker) with more than 13 minutes only for firefox. We skip firefox tests for accesibility checker, because it takes very long for a browser uses by ~5%.
Types of changes
Further comments