Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with popover visibility, replaced with display:none #2828

Merged
merged 6 commits into from
Jul 8, 2024
Merged

fix: issue with popover visibility, replaced with display:none #2828

merged 6 commits into from
Jul 8, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Jul 5, 2024

Proposed changes

closes #2804

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) July 5, 2024 13:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-2804-popover-visibility

@github-actions github-actions bot added the 🏘components Changes inside components folder label Jul 5, 2024
@nmerget nmerget requested a review from mfranzke July 8, 2024 06:06
@nmerget nmerget merged commit a913a56 into main Jul 8, 2024
51 checks passed
@nmerget nmerget deleted the fix-2804-popover-visibility branch July 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBPopover should use display:none instead of visibility:hidden?
2 participants
@nmerget @mfranzke