Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some components do not have a default font size #2812

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix: some components do not have a default font size #2812

merged 3 commits into from
Jul 5, 2024

Conversation

bruno-sch
Copy link
Collaborator

@bruno-sch bruno-sch commented Jul 1, 2024 •
edited
Loading

Proposed changes

fix: some components do not have a default font size

fixes: 2716

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@bruno-sch bruno-sch added 🐛bug Something isn't working 🎨(s)css Changes of components (s)css code labels Jul 1, 2024
@github-actions github-actions bot added the 🏘components Changes inside components folder label Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-components-default-font-size

@nmerget nmerget enabled auto-merge (squash) July 5, 2024 07:17
@nmerget nmerget merged commit 1f79eff into main Jul 5, 2024
50 checks passed
@nmerget nmerget deleted the fix-components-default-font-size branch July 5, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🐛bug Something isn't working 🏘components Changes inside components folder 🎨(s)css Changes of components (s)css code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Components that use body-font-size md falsely inherit font-sizes
2 participants
@bruno-sch @nmerget