Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: separate bg colors from semantic color classes #2791

Merged
merged 18 commits into from
Jul 5, 2024
Merged

feat: separate bg colors from semantic color classes #2791

merged 18 commits into from
Jul 5, 2024

Conversation

bruno-sch
Copy link
Collaborator

Proposed changes

Feat separate bg colors from semantic color classes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@bruno-sch bruno-sch added 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder labels Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-separate-bg-colors-from-semantic-color-classes

@github-actions github-actions bot added 📺showcases Changes to 1-n showcases and removed 📕documentation Improvements or additions to documentation labels Jun 25, 2024
@mfranzke mfranzke changed the title Feat separate bg colors from semantic color classes feat: separate bg colors from semantic color classes Jun 28, 2024
@bruno-sch bruno-sch requested a review from nmerget July 1, 2024 12:23
@nmerget nmerget enabled auto-merge (squash) July 5, 2024 09:33
nmerget added 2 commits July 5, 2024 13:36
@nmerget nmerget merged commit 3b21780 into main Jul 5, 2024
50 checks passed
@nmerget nmerget deleted the feat-separate-bg-colors-from-semantic-color-classes branch July 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruno-sch @nmerget @mfranzke