New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update stylelint to use a11y plugin #2677

Merged

nmerget merged 50 commits into main from 388-stylelint-a11y-plugin

Jul 16, 2024

Member

nmerget commented May 24, 2024 •

edited by mfranzke

Loading

Proposed changes

closes #388 & #2854

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (fix on existing components or architectural decisions)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)

Further comments


          chore: update stylelint to use a11y plugin

152bbaf

nmerget requested review from mfranzke, dkolba and annsch as code owners

May 24, 2024 08:59

Contributor

github-actions bot commented May 24, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/388-stylelint-a11y-plugin

github-actions bot added 🏗foundations 🏘components labels


          fix: issues with (prefers-reduced-motion: reduce)

371420b

nmerget enabled auto-merge (squash)

May 24, 2024 09:06

nmerget added 2 commits

May 24, 2024 13:52


          fix: issues with switch

84217a9


          chore: update from main

1f3d382

github-actions bot added the 📕documentation label

nmerget added 2 commits

June 18, 2024 08:05


          fix: issue with stylelint prefers-reduced-motion

cd08dce


          chore: update from main

084aabd

nmerget requested a review from bruno-sch as a code owner

June 24, 2024 09:56

github-actions bot added 📺showcases and removed 📕documentation labels


          chore: update from main

013ec3a

bruno-sch reviewed

View reviewed changes

packages/components/src/components/drawer/drawer.scss Outdated Show resolved Hide resolved

packages/components/src/components/navigation-item/navigation-item.scss Outdated Show resolved Hide resolved

packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved

packages/foundations/scss/colors/_placeholder.scss Outdated Show resolved Hide resolved


          fix: issue from PR

6e44485

nmerget requested a review from bruno-sch

June 28, 2024 08:18

nmerget and others added 2 commits

July 5, 2024 14:58


          chore: update from main

dee9058


          Merge branch 'main' into 388-stylelint-a11y-plugin

fe8c167

mfranzke added the 👂accessibility label

mfranzke reviewed

View reviewed changes

.stylelintrc.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

.stylelintrc.json Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

.stylelintrc.json Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

packages/components/src/components/accordion-item/accordion-item.scss Outdated Show resolved Hide resolved

mfranzke reviewed

View reviewed changes

packages/components/src/components/accordion-item/accordion-item.scss Outdated Show resolved Hide resolved


          refactor: optimization

63cca82

nmerget and others added 2 commits

July 12, 2024 09:06


          Update packages/components/src/styles/_popover-component.scss

3dfb86e

Co-authored-by: Maximilian Franzke <[email protected]>


          fix: issues from linting

304f0d9

nmerget requested a review from mfranzke

July 12, 2024 07:24

mfranzke and others added 8 commits

July 12, 2024 12:41


          refactor: added new rule

eff1df0


          fix: issue with stylelint

b432cd3


          Merge branch 'main' into 388-stylelint-a11y-plugin

c83aa4e


          Merge branch 'main' into 388-stylelint-a11y-plugin

f2ecb66


          Update navigation-item.scss

980e1cd


          Merge branch '388-stylelint-a11y-plugin' of https://github.com/db-ui/…

37d9564

…mono into 388-stylelint-a11y-plugin


          Update radio.scss

1b4bb8a


          fix: added missing character

8e4a973

mfranzke reviewed

View reviewed changes

packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved

mfranzke and others added 7 commits

July 15, 2024 12:33


          Merge branch '388-stylelint-a11y-plugin' of https://github.com/db-ui/…

7c322a1

…mono into 388-stylelint-a11y-plugin


          refactor: resilience

aaf90c8


          refactor: resilience

9fac68f


          refactor: resilience

c1ce368


          refactor: resilience

d3322eb


          refactor: resilience

7132c08


          Update _placeholder.scss

e4c18e4

mfranzke previously approved these changes

View reviewed changes


          Update switch.scss

843ccac

mfranzke dismissed their stale review via

843ccac

July 16, 2024 04:39

mfranzke added 3 commits

July 16, 2024 06:39


          Merge branch 'main' into 388-stylelint-a11y-plugin

36058d4


          refactor: regenerate lock file

fc5da79


          refactor: it seems to be possible to move these declarations anyhow

2f9aea6

mfranzke self-assigned this


          refactor: regenerate lock file

1ff94fb

mfranzke approved these changes

View reviewed changes

nmerget merged commit 9c46db0 into main

54 checks passed

nmerget deleted the 388-stylelint-a11y-plugin branch

July 16, 2024 05:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mfranzke mfranzke approved these changes

dkolba Awaiting requested review from dkolba

annsch Awaiting requested review from annsch annsch is a code owner

bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Labels

👂accessibility 🏘components 🏗foundations 📺showcases