Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable link for notification variant=overlay #2662

Merged
merged 8 commits into from
Jul 8, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented May 21, 2024

Proposed changes

closes #2651

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) May 21, 2024 09:40
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-notification-overlay-link

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels May 21, 2024
@nmerget nmerget requested a review from bruno-sch as a code owner June 27, 2024 07:30
@nmerget nmerget merged commit d3b95e6 into main Jul 8, 2024
51 checks passed
@nmerget nmerget deleted the feat-notification-overlay-link branch July 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBNotification: why does variant "overlay" omits link property?
2 participants