Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable color contrast and fix issues with components #2647

Merged
merged 26 commits into from
Jul 17, 2024
Merged

feat: enable color contrast and fix issues with components #2647

merged 26 commits into from
Jul 17, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented May 15, 2024

Proposed changes

closes #2628

  • enabled high contrast for playwright
  • fixed issues with high contrast

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) May 15, 2024 12:35
@github-actions github-actions bot added 🏗foundations Changes inside foundations folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-color-contrast

@nmerget
Copy link
Member Author

nmerget commented May 16, 2024

There is an issue with axe-playwright, I reported it already here. We should think about ignoring the rule for now :(

@nmerget nmerget marked this pull request as draft May 16, 2024 10:05
auto-merge was automatically disabled May 16, 2024 10:05

Pull request was converted to draft

@nmerget nmerget marked this pull request as ready for review May 17, 2024 13:59
@nmerget nmerget enabled auto-merge (squash) May 17, 2024 13:59
@nmerget nmerget requested a review from mfranzke May 21, 2024 06:58
@nmerget nmerget requested a review from bruno-sch as a code owner June 26, 2024 13:37
@nmerget nmerget requested a review from bruno-sch July 5, 2024 12:29
@nmerget nmerget added the 👂accessibility Accessibility issues/improvements label Jul 8, 2024
mfranzke
mfranzke previously approved these changes Jul 16, 2024
View reviewed changes
@mfranzke mfranzke self-assigned this Jul 16, 2024
@nmerget nmerget requested a review from mfranzke July 17, 2024 06:24
mfranzke
mfranzke previously approved these changes Jul 17, 2024
View reviewed changes
@nmerget nmerget merged commit a809de7 into main Jul 17, 2024
55 checks passed
@nmerget nmerget deleted the feat-color-contrast branch July 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
👂accessibility Accessibility issues/improvements 🏘components Changes inside components folder 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch: doesn't work with High Contrast mode
3 participants
@nmerget @mfranzke @bruno-sch