Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues with header with wrong spacings and dividers based on slots #2611

Merged
merged 8 commits into from
May 10, 2024
Merged

fix: issues with header with wrong spacings and dividers based on slots #2611

merged 8 commits into from
May 10, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented May 6, 2024 •
edited by mfranzke
Loading

Proposed changes

DBSWC-2706

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested review from mfranzke, dkolba and annsch as code owners May 6, 2024 11:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-header-issues

@nmerget nmerget enabled auto-merge (squash) May 6, 2024 11:16
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels May 6, 2024
@nmerget nmerget requested a review from bruno-sch May 8, 2024 11:55
@mfranzke mfranzke mentioned this pull request May 10, 2024
Open
mfranzke
mfranzke previously approved these changes May 10, 2024
View reviewed changes
@mfranzke mfranzke self-assigned this May 10, 2024
@nmerget nmerget requested a review from mfranzke May 10, 2024 08:30
@nmerget nmerget merged commit 15556f1 into main May 10, 2024
28 checks passed
@nmerget nmerget deleted the fix-header-issues branch May 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

@bruno-sch bruno-sch

Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmerget @mfranzke @bruno-sch