Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a11y form component ids #2599

Merged
merged 53 commits into from
Jul 10, 2024
Merged

Fix a11y form component ids #2599

merged 53 commits into from
Jul 10, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Apr 30, 2024 •
edited
Loading

Proposed changes

closes #2588

  • changed form-components to work with aria-describedby and messages
  • add new showcase tests to check if every framework works with every specific form implementation to make sure nothing breaks

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-a11y-form-component-ids

@github-actions github-actions bot added the 🏘components Changes inside components folder label Apr 30, 2024
@nmerget nmerget enabled auto-merge (squash) April 30, 2024 14:47
@nmerget nmerget marked this pull request as draft April 30, 2024 15:25
auto-merge was automatically disabled April 30, 2024 15:25

Pull request was converted to draft

@nmerget nmerget marked this pull request as ready for review May 3, 2024 05:54
@nmerget nmerget enabled auto-merge (squash) May 6, 2024 06:06
@nmerget nmerget requested a review from mfranzke May 8, 2024 14:56
nmerget and others added 5 commits July 9, 2024 12:25
@nmerget nmerget requested a review from mfranzke July 9, 2024 10:26
@mfranzke
Copy link
Member

mfranzke commented Jul 9, 2024 •
edited
Loading

@nmerget I've extracted some optimizations into #2849, so after merging #2849, this PR should be fine as well to get merged.

nmerget and others added 4 commits July 10, 2024 13:25
@nmerget nmerget requested a review from mfranzke July 10, 2024 11:29
@nmerget nmerget merged commit 054b8e8 into main Jul 10, 2024
51 checks passed
@nmerget nmerget deleted the fix-a11y-form-component-ids branch July 10, 2024 15:47
@mfranzke mfranzke self-assigned this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees

@mfranzke mfranzke

Labels
👂accessibility Accessibility issues/improvements 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form Components: Accessibility Tree not updating when id changes Showcase: unify forms
3 participants
@nmerget @mfranzke @bruno-sch