Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with user-valid for form-components #2496

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: issue with user-valid for form-components #2496

merged 3 commits into from
Apr 11, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Apr 11, 2024

Proposed changes

Add correct :user-valid for checkbox and select

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) April 11, 2024 10:04
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-user-valid

@github-actions github-actions bot added the 🏘components Changes inside components folder label Apr 11, 2024
mfranzke
mfranzke previously approved these changes Apr 11, 2024
View reviewed changes
@mfranzke mfranzke changed the title fix: issue with user-valid for form-components fix: issue with user-valid for form-components Apr 11, 2024
@nmerget nmerget requested review from mfranzke and annsch April 11, 2024 10:49
@nmerget nmerget merged commit 91ba8bf into main Apr 11, 2024
27 checks passed
@nmerget nmerget deleted the fix-user-valid branch April 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmerget @mfranzke @annsch