Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: links with foundation readme #2487

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: links with foundation readme #2487

merged 1 commit into from
Apr 10, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Apr 10, 2024

Proposed changes

closes #2408

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder labels Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-links-foundations-readme

@mfranzke mfranzke merged commit aa804ab into main Apr 10, 2024
29 checks passed
@mfranzke mfranzke deleted the fix-links-foundations-readme branch April 10, 2024 14:42
@mfranzke mfranzke self-assigned this Apr 10, 2024
@mfranzke mfranzke added this to the Open Beta Release milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.

docs(foundations): README links open in a new tab unexpectatly
2 participants
@nmerget @mfranzke