Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto close to nav-item inside header and main-navigation #2344

Merged
merged 8 commits into from
Apr 11, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Mar 18, 2024

Proposed changes

closes #2276

  • add auto-close for navigation-items

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-auto-close-nav-item

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Mar 18, 2024
@nmerget nmerget enabled auto-merge (squash) March 18, 2024 16:42
nmerget added 3 commits March 19, 2024 07:58
…-item

# Conflicts:
#	packages/components/src/components/main-navigation/main-navigation.lite.tsx
@nmerget nmerget requested a review from mfranzke March 22, 2024 08:05
@github-actions github-actions bot removed the 📺showcases Changes to 1-n showcases label Mar 22, 2024
@nmerget nmerget merged commit e6f091d into main Apr 11, 2024
28 checks passed
@nmerget nmerget deleted the feat-auto-close-nav-item branch April 11, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBNavigationItem doesn't auto-close
2 participants