Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare patternhub to use static assets provided by react sc #2342

Merged
merged 5 commits into from
Apr 11, 2024
Merged

chore: prepare patternhub to use static assets provided by react sc #2342

merged 5 commits into from
Apr 11, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Mar 18, 2024

Proposed changes

New notification (former alert) will use custom images which are static assets

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/chore-patternhub-static-assets

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Mar 18, 2024
@nmerget nmerget enabled auto-merge (squash) March 18, 2024 11:50
@nmerget nmerget added this to the Open Beta Release milestone Mar 20, 2024
@mfranzke mfranzke self-assigned this Apr 10, 2024
@nmerget nmerget merged commit 945cc18 into main Apr 11, 2024
28 checks passed
@nmerget nmerget deleted the chore-patternhub-static-assets branch April 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke