Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add switch component #2296

Merged
merged 200 commits into from
Apr 30, 2024
Merged

feat: add switch component #2296

merged 200 commits into from
Apr 30, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Mar 5, 2024

Proposed changes

Add switch component; resolves #2139

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

dependabot bot and others added 30 commits November 17, 2023 10:15
Bumps the playwright group with 3 updates: [@playwright/test](https://github.com/microsoft/playwright), [@playwright/experimental-ct-react](https://github.com/microsoft/playwright) and [@playwright/experimental-ct-vue](https://github.com/microsoft/playwright).


Updates `@playwright/test` from 1.35.1 to 1.40.0
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.35.1...v1.40.0)

Updates `@playwright/experimental-ct-react` from 1.35.1 to 1.40.0
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.35.1...v1.40.0)

Updates `@playwright/experimental-ct-vue` from 1.35.1 to 1.40.0
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.35.1...v1.40.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: playwright
- dependency-name: "@playwright/experimental-ct-react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: playwright
- dependency-name: "@playwright/experimental-ct-vue"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: playwright
...

Signed-off-by: dependabot[bot] <[email protected]>
…yarn-playwright-45bfcbf8a4

# Conflicts:
#	package-lock.json
…ht-45bfcbf8a4' into dependabot-npm_and_yarn-playwright-45bfcbf8a4
…b.com:db-ui/mono into feat-color-palette

# Conflicts:
#	__snapshots__/alert/component/chromium/DBAlert-should-match-screenshot-for-variant-informational.png
#	__snapshots__/alert/component/chromium/DBAlert-should-match-screenshot-for-variant-successful.png
#	__snapshots__/alert/component/chromium/DBAlert-should-match-screenshot-for-variant-warning.png
#	__snapshots__/alert/component/mobile-chrome/DBAlert-should-match-screenshot-for-variant-informational.png
#	__snapshots__/alert/component/mobile-chrome/DBAlert-should-match-screenshot-for-variant-successful.png
#	__snapshots__/alert/component/mobile-chrome/DBAlert-should-match-screenshot-for-variant-warning.png
#	__snapshots__/alert/component/mobile-safari/DBAlert-should-match-screenshot-for-variant-informational.png
#	__snapshots__/alert/component/mobile-safari/DBAlert-should-match-screenshot-for-variant-successful.png
#	__snapshots__/alert/component/mobile-safari/DBAlert-should-match-screenshot-for-variant-warning.png
#	__snapshots__/alert/component/webkit/DBAlert-should-match-screenshot-for-variant-informational.png
#	__snapshots__/alert/component/webkit/DBAlert-should-match-screenshot-for-variant-successful.png
#	__snapshots__/alert/component/webkit/DBAlert-should-match-screenshot-for-variant-warning.png
#	__snapshots__/alert/showcase/chromium/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/alert/showcase/mobile-chrome/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/alert/showcase/mobile-safari/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/alert/showcase/webkit/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/badge/showcase/chromium/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/mobile-chrome/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/mobile-safari/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/webkit/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/brand/component/chromium/DBBrand-should-match-screenshot.png
#	__snapshots__/brand/component/mobile-chrome/DBBrand-should-match-screenshot.png
#	__snapshots__/button/component/mobile-safari/DBButton-should-only-have-icon-for-variant-outlined.png
#	__snapshots__/button/component/mobile-safari/DBButton-should-only-have-icon-for-variant-primary.png
#	__snapshots__/infotext/component/mobile-safari/DBInfotext-should-match-screenshot-for-variant-critical.png
#	__snapshots__/infotext/component/mobile-safari/DBInfotext-should-match-screenshot-for-variant-informational.png
#	__snapshots__/infotext/component/mobile-safari/DBInfotext-should-match-screenshot-for-variant-successful.png
#	__snapshots__/infotext/component/mobile-safari/DBInfotext-should-match-screenshot.png
#	__snapshots__/input/showcase/chromium/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-chrome/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-safari/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/webkit/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/tag/component/chromium/DBTag-should-match-screenshot-for-variant-informational.png
#	__snapshots__/tag/component/chromium/DBTag-should-match-screenshot-for-variant-successful.png
#	__snapshots__/tag/component/chromium/DBTag-should-match-screenshot-for-variant-warning.png
#	__snapshots__/tag/component/mobile-chrome/DBTag-should-match-screenshot-for-variant-informational.png
#	__snapshots__/tag/component/mobile-chrome/DBTag-should-match-screenshot-for-variant-successful.png
#	__snapshots__/tag/component/mobile-chrome/DBTag-should-match-screenshot-for-variant-warning.png
#	__snapshots__/tag/component/mobile-safari/DBTag-should-match-screenshot-for-variant-informational.png
#	__snapshots__/tag/component/mobile-safari/DBTag-should-match-screenshot-for-variant-successful.png
#	__snapshots__/tag/component/mobile-safari/DBTag-should-match-screenshot-for-variant-warning.png
#	__snapshots__/tag/component/webkit/DBTag-should-match-screenshot-for-variant-informational.png
#	__snapshots__/tag/component/webkit/DBTag-should-match-screenshot-for-variant-successful.png
#	__snapshots__/tag/component/webkit/DBTag-should-match-screenshot-for-variant-warning.png
#	__snapshots__/tag/showcase/chromium/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/tag/showcase/mobile-chrome/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/tag/showcase/mobile-safari/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/tag/showcase/webkit/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/textarea/component/mobile-chrome/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/chromium/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-chrome/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-safari/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/webkit/regular/neutral/DBTextarea-should-match-screenshot.png
# Conflicts:
#	output/react/package.json
#	package-lock.json
# Conflicts:
#	__snapshots__/alert/component/chromium/DBAlert-should-match-screenshot-for-variant-informational.png
#	__snapshots__/alert/component/chromium/DBAlert-should-match-screenshot-for-variant-successful.png
#	__snapshots__/alert/component/chromium/DBAlert-should-match-screenshot-for-variant-warning.png
#	__snapshots__/alert/component/mobile-chrome/DBAlert-should-match-screenshot-for-variant-informational.png
#	__snapshots__/alert/component/mobile-chrome/DBAlert-should-match-screenshot-for-variant-successful.png
#	__snapshots__/alert/component/mobile-chrome/DBAlert-should-match-screenshot-for-variant-warning.png
#	__snapshots__/alert/showcase/chromium/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/alert/showcase/mobile-chrome/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/alert/showcase/mobile-safari/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/alert/showcase/webkit/regular/neutral/DBAlert-should-match-screenshot.png
#	__snapshots__/badge/showcase/chromium/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/mobile-chrome/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/mobile-safari/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/webkit/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/input/showcase/chromium/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-chrome/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-safari/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/webkit/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/tag/component/chromium/DBTag-should-match-screenshot-for-variant-informational.png
#	__snapshots__/tag/component/chromium/DBTag-should-match-screenshot-for-variant-successful.png
#	__snapshots__/tag/component/chromium/DBTag-should-match-screenshot-for-variant-warning.png
#	__snapshots__/tag/component/mobile-chrome/DBTag-should-match-screenshot-for-variant-informational.png
#	__snapshots__/tag/component/mobile-chrome/DBTag-should-match-screenshot-for-variant-successful.png
#	__snapshots__/tag/component/mobile-chrome/DBTag-should-match-screenshot-for-variant-warning.png
#	__snapshots__/tag/showcase/chromium/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/tag/showcase/mobile-chrome/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/tag/showcase/mobile-safari/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/tag/showcase/webkit/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/textarea/showcase/chromium/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-chrome/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-safari/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/webkit/regular/neutral/DBTextarea-should-match-screenshot.png
#	packages/components/src/styles/_form-components.scss
# Conflicts:
#	__snapshots__/input/showcase/chromium/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-chrome/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-safari/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/webkit/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/textarea/showcase/chromium/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-chrome/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-safari/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/webkit/regular/neutral/DBTextarea-should-match-screenshot.png
@nmerget nmerget self-assigned this Apr 24, 2024
@nmerget nmerget enabled auto-merge (squash) April 25, 2024 05:55
@nmerget nmerget requested a review from mfranzke April 25, 2024 07:43
@nmerget nmerget assigned bruno-sch and unassigned nmerget Apr 25, 2024
Copy link
Collaborator

@bruno-sch bruno-sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, elaborate CSS. The animation on click feels really good :)

packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved
packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved
packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved
packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved
packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved
packages/components/src/components/switch/switch.scss Outdated Show resolved Hide resolved
packages/foundations/scss/_focus.scss Outdated Show resolved Hide resolved
@nmerget nmerget requested a review from bruno-sch April 30, 2024 06:18
@nmerget nmerget requested a review from bruno-sch April 30, 2024 09:42
@nmerget nmerget merged commit ee773a5 into main Apr 30, 2024
28 checks passed
@nmerget nmerget deleted the feat-switch branch April 30, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch - Concept
3 participants