-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(icons): prevent the textual representation from being announced #2040
refactor(icons): prevent the textual representation from being announced #2040
Conversation
by providing an empty alternative text
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2036-testa11y-icon-would-get-announced-by-screenreaders-within-buttons |
…reenreaders-within-buttons
as suggested by @nmerget
Do we need the mixin here as well? A screen-reader might speak "none" otherwise |
Have you actually tested this? Judged by the specs, the pseudo-element wouldn't get rendered at all: |
It was a question. But yes I tested it and it is removed from DOM completely |
…reenreaders-within-buttons
by providing an empty alternative text
Proposed changes
Resolves #2036
Types of changes
Further comments