Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(icons): prevent the textual representation from being announced #2040

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Jan 5, 2024

by providing an empty alternative text

Proposed changes

Resolves #2036

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🐛bug Something isn't working 👂accessibility Accessibility issues/improvements labels Jan 5, 2024
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Jan 5, 2024
@mfranzke mfranzke self-assigned this Jan 5, 2024
@mfranzke mfranzke linked an issue Jan 5, 2024 that may be closed by this pull request
7 tasks
Copy link
Contributor

github-actions bot commented Jan 5, 2024

@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Apr 19, 2024
@mfranzke mfranzke marked this pull request as ready for review April 19, 2024 13:03
@mfranzke mfranzke removed their assignment Apr 19, 2024
@mfranzke mfranzke enabled auto-merge April 19, 2024 19:45
@nmerget
Copy link
Member

nmerget commented Apr 22, 2024

Do we need the mixin here as well? A screen-reader might speak "none" otherwise

@mfranzke
Copy link
Member Author

mfranzke commented Apr 22, 2024

Do we need the mixin here as well? A screen-reader might speak "none" otherwise

Have you actually tested this? Judged by the specs, the pseudo-element wouldn't get rendered at all:
https://developer.mozilla.org/en-US/docs/Web/CSS/content?retiredLocale=de#none

@nmerget
Copy link
Member

nmerget commented Apr 22, 2024

Do we need the mixin here as well? A screen-reader might speak "none" otherwise

Have you actually tested this? Judged by the specs, the pseudo-element wouldn't get rendered at all: https://developer.mozilla.org/en-US/docs/Web/CSS/content?retiredLocale=de#none

It was a question. But yes I tested it and it is removed from DOM completely

@mfranzke mfranzke merged commit 5a68a93 into main Apr 22, 2024
27 checks passed
@mfranzke mfranzke deleted the 2036-testa11y-icon-would-get-announced-by-screenreaders-within-buttons branch April 22, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👂accessibility Accessibility issues/improvements 🐛bug Something isn't working 🏗foundations Changes inside foundations folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(a11y): Icon would get announced by screenreaders within buttons
2 participants