Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: asset upload #1962

Merged
merged 6 commits into from
Dec 5, 2023
Merged

fix: asset upload #1962

merged 6 commits into from
Dec 5, 2023

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Dec 5, 2023 •
edited
Loading

Proposed changes

  • fix issue with uploading assets, oktakit wraps everything in data

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-asset-upload

@nmerget nmerget marked this pull request as ready for review December 5, 2023 12:33
@nmerget nmerget enabled auto-merge (squash) December 5, 2023 12:40
@nmerget nmerget merged commit c5525d4 into main Dec 5, 2023
25 checks passed
@nmerget nmerget deleted the fix-asset-upload branch December 5, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annsch annsch annsch approved these changes

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@dkolba dkolba Awaiting requested review from dkolba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @annsch