Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated xo dependency #1959

Merged
merged 42 commits into from
Feb 28, 2024
Merged

refactor: updated xo dependency #1959

merged 42 commits into from
Feb 28, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 5, 2023

Proposed changes

Updated xo dependency and made code updates regarding xo feedback. And needed to run prettier again on the codebase.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added 🍄🆙improvement New feature or request 🤫dependencies Pull requests that update a dependency file labels Dec 5, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Dec 5, 2023
@mfranzke mfranzke self-assigned this Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-update-xo

@mfranzke mfranzke marked this pull request as ready for review December 5, 2023 06:16
@mfranzke mfranzke enabled auto-merge December 5, 2023 06:16
@annsch
Copy link
Collaborator

annsch commented Dec 15, 2023

@mfranzke could you explain why you switched from replace to replaceAll? This could lead from an issue in XO but for review issues it would be easier to understand if it's documented in PR's description ... without explanation I don't understand the mix of this PR :)

@mfranzke
Copy link
Member Author

@mfranzke could you explain why you switched from replace to replaceAll? This could lead from an issue in XO but for review issues it would be easier to understand if it's documented in PR's description ... without explanation I don't understand the mix of this PR :)

valid aspect, thanks. I've added xo code styles feedback as well to this PR, and added this aspects within the description.

annsch
annsch previously approved these changes Dec 15, 2023
@mfranzke mfranzke changed the title refactor: updated xo dependency refactor: updated xo dependency Jan 12, 2024
@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Jan 23, 2024
@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Feb 8, 2024
@mfranzke mfranzke removed their assignment Feb 24, 2024
@nmerget nmerget self-requested a review February 27, 2024 09:30
nmerget
nmerget previously approved these changes Feb 27, 2024
@mfranzke mfranzke merged commit 3e6ba17 into main Feb 28, 2024
26 checks passed
@mfranzke mfranzke deleted the refactor-update-xo branch February 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢📀cicd Changes inside .github folder 🏘components Changes inside components folder 🤫dependencies Pull requests that update a dependency file 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants