Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: brand component #1937

Merged
merged 58 commits into from
Apr 16, 2024
Merged

refactor: brand component #1937

merged 58 commits into from
Apr 16, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Dec 1, 2023

Proposed changes

closes #1574

  • reworked brand completely

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 🏗foundations Changes inside foundations folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Dec 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-brand

@nmerget nmerget enabled auto-merge (squash) December 4, 2023 12:18
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Dec 10, 2023
@mfranzke mfranzke marked this pull request as draft December 10, 2023 11:43
auto-merge was automatically disabled December 10, 2023 11:43

Pull request was converted to draft

@mfranzke
Copy link
Member

set to draft as the pipeline fails.

@nmerget nmerget marked this pull request as ready for review January 2, 2024 15:28
@nmerget nmerget enabled auto-merge (squash) January 2, 2024 15:29
@bruno-sch bruno-sch linked an issue Apr 15, 2024 that may be closed by this pull request
DBBrand component doesn't load default image #2413
Closed
7 tasks
nmerget added 4 commits April 15, 2024 17:03
@nmerget
chore: update snapshots
8dcfc11
@nmerget
Merge remote-tracking branch 'origin/refactor-brand' into refactor-brand
2a32fdb 
# Conflicts:
#	__snapshots__/brand/component/chromium/DBBrand-should-match-screenshot.png
#	__snapshots__/brand/component/firefox/DBBrand-should-match-screenshot.png
#	__snapshots__/brand/component/mobile-chrome/DBBrand-should-match-screenshot.png
#	__snapshots__/brand/showcase/chromium/regular/neutral/DBBrand-should-match-screenshot.png
#	__snapshots__/brand/showcase/firefox/regular/neutral/DBBrand-should-match-screenshot.png
#	__snapshots__/brand/showcase/webkit/regular/neutral/DBBrand-should-match-screenshot.png
#	__snapshots__/tabs/showcase/chromium/regular/neutral/DBTabs-should-match-screenshot.png
#	__snapshots__/tabs/showcase/firefox/regular/neutral/DBTabs-should-match-screenshot.png
@nmerget
Merge branch 'main' of github.com:db-ui/mono into refactor-brand
4c125e4 
# Conflicts:
#	__snapshots__/accordion-item/showcase/chromium/regular/neutral/DBAccordionItem-should-match-screenshot.png
#	__snapshots__/accordion-item/showcase/firefox/regular/neutral/DBAccordionItem-should-match-screenshot.png
#	__snapshots__/accordion/showcase/chromium/regular/neutral/DBAccordion-should-match-screenshot.png
#	__snapshots__/accordion/showcase/firefox/regular/neutral/DBAccordion-should-match-screenshot.png
#	__snapshots__/accordion/showcase/webkit/regular/neutral/DBAccordion-should-match-screenshot.png
#	__snapshots__/badge/showcase/chromium/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/badge/showcase/firefox/regular/neutral/DBBadge-should-match-screenshot.png
#	__snapshots__/infotext/showcase/chromium/regular/neutral/DBInfotext-should-match-screenshot.png
#	__snapshots__/infotext/showcase/firefox/regular/neutral/DBInfotext-should-match-screenshot.png
#	__snapshots__/input/showcase/chromium/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/firefox/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/webkit/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/notification/showcase/chromium/regular/neutral/DBNotification-should-match-screenshot.png
#	__snapshots__/notification/showcase/firefox/regular/neutral/DBNotification-should-match-screenshot.png
#	__snapshots__/notification/showcase/webkit/regular/neutral/DBNotification-should-match-screenshot.png
#	__snapshots__/tab/showcase/chromium/regular/neutral/DBTab-should-match-screenshot.png
#	__snapshots__/tab/showcase/firefox/regular/neutral/DBTab-should-match-screenshot.png
#	__snapshots__/tab/showcase/webkit/regular/neutral/DBTab-should-match-screenshot.png
#	packages/foundations/assets/icons/functional/fonts/all/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default_16/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default_20/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default_24/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default_32/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default_48/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/default_64/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted_16/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted_20/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted_24/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted_32/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted_48/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/inverted_64/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid_16/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid_20/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid_24/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid_32/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid_48/db-ux.woff2
#	packages/foundations/assets/icons/functional/fonts/solid_64/db-ux.woff2
#	packages/foundations/assets/icons/functional/images/brand/db_ic_logo_20.svg
#	packages/foundations/assets/icons/functional/images/brand/db_ic_logo_24.svg
#	packages/foundations/assets/icons/functional/images/brand/db_ic_logo_32.svg
#	packages/foundations/assets/icons/functional/images/brand/db_ic_logo_48.svg
#	packages/foundations/assets/icons/functional/images/brand/db_ic_logo_64.svg
@nmerget
chore: update from main
a3f24e9
@github-actions github-actions bot removed the 🏗foundations Changes inside foundations folder label Apr 15, 2024
@mfranzke mfranzke self-assigned this Apr 16, 2024
@nmerget nmerget merged commit 2328c0c into main Apr 16, 2024
27 checks passed
@nmerget nmerget deleted the refactor-brand branch April 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-koppenhagen d-koppenhagen d-koppenhagen left review comments

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.

DBBrand component doesn't load default image Header: why is the logo always supposed to get a link?
3 participants
@nmerget @mfranzke @d-koppenhagen