Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tag): enabled keyboard focusability again #1880

Merged
merged 6 commits into from
Feb 9, 2024
Merged

refactor(tag): enabled keyboard focusability again #1880

merged 6 commits into from
Feb 9, 2024

Conversation

mfranzke
Copy link
Member

Proposed changes

Resolves #1879

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🐛bug Something isn't working label Nov 21, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Nov 21, 2023
@mfranzke mfranzke self-assigned this Nov 21, 2023
@mfranzke mfranzke linked an issue Nov 21, 2023 that may be closed by this pull request
Tag: checkbox and radio behaviours aren't possible to get focussed via keyboard #1879
Closed
7 tasks
@mfranzke mfranzke marked this pull request as ready for review November 21, 2023 14:58
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/1879-tag-checkbox-and-radio-behaviours-arent-possible-to-get-focussed-via-keyboard

@mfranzke mfranzke enabled auto-merge November 21, 2023 15:26
@nmerget
Copy link
Member

nmerget commented Nov 22, 2023

image
Should it look like this? :O

@mfranzke
Copy link
Member Author

image Should it look like this? :O

No, I haven't had that test case in mind … :-(

@mfranzke mfranzke marked this pull request as draft November 22, 2023 09:04
auto-merge was automatically disabled November 22, 2023 09:04

Pull request was converted to draft

@mfranzke mfranzke changed the title refactor: enabled keyboard focusability again refactor(tag): enabled keyboard focusability again Dec 5, 2023
@github-actions github-actions bot added the 🏘components Changes inside components folder label Feb 9, 2024
@nmerget nmerget assigned nmerget and unassigned mfranzke Feb 9, 2024
@nmerget nmerget marked this pull request as ready for review February 9, 2024 08:46
@nmerget nmerget enabled auto-merge (squash) February 9, 2024 08:46
@nmerget nmerget merged commit 58ee52c into main Feb 9, 2024
25 checks passed
@nmerget nmerget deleted the 1879-tag-checkbox-and-radio-behaviours-arent-possible-to-get-focussed-via-keyboard branch February 9, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@nmerget nmerget

Labels
🐛bug Something isn't working 🏘components Changes inside components folder
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.

Tag: checkbox and radio behaviours aren't possible to get focussed via keyboard
2 participants
@mfranzke @nmerget