Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: we need to actually prettify JS files as well #1866

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix: we need to actually prettify JS files as well #1866

merged 4 commits into from
Nov 20, 2023

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Nov 17, 2023 •
edited
Loading

Proposed changes

it's not done by just running xo

Resolves #1847

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🐛bug Something isn't working label Nov 17, 2023
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Nov 17, 2023
@mfranzke mfranzke self-assigned this Nov 17, 2023
@mfranzke mfranzke linked an issue Nov 17, 2023 that may be closed by this pull request
Check on why .ts files won't get prettyfied #1847
Closed
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/1847-check-on-why-ts-files-wont-get-prettyfied

nmerget
nmerget reviewed Nov 20, 2023
View reviewed changes
.lintstagedrc.js Outdated Show resolved Hide resolved
@mfranzke mfranzke requested a review from nmerget November 20, 2023 09:45
@mfranzke mfranzke enabled auto-merge November 20, 2023 09:45
@mfranzke mfranzke merged commit e62eede into main Nov 20, 2023
28 checks passed
@mfranzke mfranzke deleted the 1847-check-on-why-ts-files-wont-get-prettyfied branch November 20, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
🐛bug Something isn't working
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.

Check on why .ts files won't get prettyfied
2 participants
@mfranzke @nmerget