Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(showcases): moved hidden label to another section #1850

Merged
merged 15 commits into from
Nov 28, 2023
Merged

docs(showcases): moved hidden label to another section #1850

merged 15 commits into from
Nov 28, 2023

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 17, 2023

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/chore-label-variant-showcase

@nmerget nmerget enabled auto-merge (squash) November 17, 2023 09:43
@mfranzke mfranzke changed the title chore: update showcases moved hidden label to another section docs(showcases): moved hidden label to another section Nov 23, 2023
mfranzke
mfranzke previously approved these changes Nov 23, 2023
View reviewed changes
@mfranzke mfranzke marked this pull request as draft November 23, 2023 06:51
auto-merge was automatically disabled November 23, 2023 06:51

Pull request was converted to draft

@github-actions github-actions bot added 🚢📀cicd Changes inside .github folder 🏘components Changes inside components folder labels Nov 23, 2023
@github-actions github-actions bot removed 🚢📀cicd Changes inside .github folder 🏘components Changes inside components folder labels Nov 23, 2023
mfranzke
mfranzke previously approved these changes Nov 23, 2023
View reviewed changes
@mfranzke mfranzke marked this pull request as ready for review November 23, 2023 11:22
@mfranzke mfranzke enabled auto-merge November 23, 2023 11:22
@nmerget
Merge branch 'main' of github.com:db-ui/mono into chore-label-variant…
1f923ea 
…-showcase

# Conflicts:
#	__snapshots__/accordion-item/component/webkit/DBAccordionItem-should-match-screenshot.png
#	__snapshots__/accordion/component/webkit/DBAccordion-should-match-screenshot.png
#	__snapshots__/button/component/mobile-safari/DBButton-should-only-have-icon-for-variant-primary.png
#	__snapshots__/button/component/mobile-safari/DBButton-should-only-have-icon-for-variant-solid.png
#	__snapshots__/button/component/webkit/DBButton-should-only-have-icon-for-variant-outlined.png
#	__snapshots__/button/component/webkit/DBButton-should-only-have-icon-for-variant-primary.png
#	__snapshots__/button/component/webkit/DBButton-should-only-have-icon-for-variant-text.png
#	__snapshots__/infotext/component/webkit/DBInfotext-should-match-screenshot-for-variant-critical.png
#	__snapshots__/infotext/component/webkit/DBInfotext-should-match-screenshot-for-variant-informational.png
#	__snapshots__/infotext/component/webkit/DBInfotext-should-match-screenshot-for-variant-successful.png
#	__snapshots__/infotext/component/webkit/DBInfotext-should-match-screenshot-for-variant-warning.png
#	__snapshots__/infotext/component/webkit/DBInfotext-should-match-screenshot.png
#	__snapshots__/input/showcase/chromium/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-chrome/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-safari/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/webkit/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/select/component/webkit/DBSelect-should-match-screenshot.png
#	__snapshots__/tag/showcase/mobile-safari/regular/neutral/DBTag-should-match-screenshot.png
#	__snapshots__/textarea/showcase/chromium/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-chrome/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-safari/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/webkit/regular/neutral/DBTextarea-should-match-screenshot.png
@nmerget
chore: update from main
4d4cad2
@nmerget
Merge branch 'main' of github.com:db-ui/mono into chore-label-variant…
4976834 
…-showcase

# Conflicts:
#	__snapshots__/input/showcase/chromium/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/input/showcase/mobile-chrome/regular/neutral/DBInput-should-match-screenshot.png
#	__snapshots__/textarea/showcase/chromium/regular/neutral/DBTextarea-should-match-screenshot.png
#	__snapshots__/textarea/showcase/mobile-chrome/regular/neutral/DBTextarea-should-match-screenshot.png
@nmerget
chore: update from main
a7dda99
@nmerget nmerget requested a review from mfranzke November 28, 2023 11:56
@mfranzke mfranzke merged commit 5dce75e into main Nov 28, 2023
25 checks passed
@mfranzke mfranzke deleted the chore-label-variant-showcase branch November 28, 2023 12:08
@mfranzke mfranzke removed request for dkolba and annsch November 28, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

Assignees
No one assigned
Labels
📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke