Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional popover placements #1763

Merged
merged 2 commits into from
Nov 2, 2023
Merged

feat: add additional popover placements #1763

merged 2 commits into from
Nov 2, 2023

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 1, 2023

Proposed changes

Add additional placements for popover and tooltip.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-popover-placements

@mfranzke mfranzke removed request for dkolba and annsch November 2, 2023 11:38
@nmerget nmerget enabled auto-merge (squash) November 2, 2023 16:41
@nmerget nmerget requested a review from mfranzke November 2, 2023 16:41
@nmerget nmerget merged commit 1b8d76e into main Nov 2, 2023
29 checks passed
@nmerget nmerget deleted the feat-popover-placements branch November 2, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

Assignees

@nmerget nmerget

Labels
🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke