Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generate-icon-font to use it as bin executable and update d… #1754

Merged
merged 11 commits into from
Oct 31, 2023
Merged

refactor: generate-icon-font to use it as bin executable and update d… #1754

merged 11 commits into from
Oct 31, 2023

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Oct 31, 2023

…ocumentation

Proposed changes

  • made generate-icon-fonts executable
  • split documentation for custom icons

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget removed request for dkolba and mfranzke October 31, 2023 10:11
@nmerget nmerget enabled auto-merge (squash) October 31, 2023 10:11
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-generate-icons-exec

@github-actions github-actions bot added 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases labels Oct 31, 2023
@annsch annsch disabled auto-merge October 31, 2023 14:06
annsch
annsch previously approved these changes Oct 31, 2023
View reviewed changes
@nmerget nmerget enabled auto-merge (squash) October 31, 2023 14:08
@nmerget nmerget requested review from annsch and mfranzke October 31, 2023 15:24
@nmerget nmerget merged commit 03a2295 into main Oct 31, 2023
29 checks passed
@nmerget nmerget deleted the refactor-generate-icons-exec branch October 31, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmerget @mfranzke @annsch