-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into 2967-slow-performance-css-selectors
- Loading branch information
Showing
202 changed files
with
3,091 additions
and
1,813 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+109 Bytes
(100%)
...ighContrast/DBCard-should-match-screenshot-1/DBCard-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
...se/chromium/DBCard-should-match-screenshot-1/DBCard-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.08 KB
(100%)
...ase/firefox/DBCard-should-match-screenshot-1/DBCard-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 Bytes
(100%)
...bile-chrome/DBCard-should-match-screenshot-1/DBCard-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...bile-safari/DBCard-should-match-screenshot-1/DBCard-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+57 Bytes
(100%)
...case/webkit/DBCard-should-match-screenshot-1/DBCard-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.01 KB
(110%)
__snapshots__/divider/patternhub/divider-properties-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-392 Bytes
(99%)
...ontrast/DBDrawer-should-match-screenshot-1/DBDrawer-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-513 Bytes
(99%)
...hromium/DBDrawer-should-match-screenshot-1/DBDrawer-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-311 Bytes
(100%)
...firefox/DBDrawer-should-match-screenshot-1/DBDrawer-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-965 Bytes
(99%)
...-chrome/DBDrawer-should-match-screenshot-1/DBDrawer-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-961 Bytes
(99%)
...-safari/DBDrawer-should-match-screenshot-1/DBDrawer-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-468 Bytes
(99%)
.../webkit/DBDrawer-should-match-screenshot-1/DBDrawer-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.24 KB
(100%)
...hContrast/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5.51 KB
(100%)
.../chromium/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7.36 KB
(100%)
...e/firefox/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6.14 KB
(100%)
...le-chrome/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6.42 KB
(110%)
...le-safari/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5.72 KB
(100%)
...se/webkit/DBInput-should-match-screenshot-1/DBInput-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2.72 KB
(100%)
...trast/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+3.03 KB
(100%)
...omium/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7.08 KB
(100%)
...refox/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+580 Bytes
(100%)
...hrome/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-207 Bytes
(100%)
...afari/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+548 Bytes
(100%)
...ebkit/DBPopover-should-match-screenshot-1/DBPopover-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+470 Bytes
(100%)
...trast/DBSection-should-match-screenshot-1/DBSection-should-match-screenshot.png
Oops, something went wrong.
Binary file modified
BIN
+501 Bytes
(100%)
...omium/DBSection-should-match-screenshot-1/DBSection-should-match-screenshot.png
Oops, something went wrong.
Binary file modified
BIN
+1019 Bytes
(100%)
...refox/DBSection-should-match-screenshot-1/DBSection-should-match-screenshot.png
Oops, something went wrong.
Binary file modified
BIN
+672 Bytes
(100%)
...hrome/DBSection-should-match-screenshot-1/DBSection-should-match-screenshot.png
Oops, something went wrong.
Binary file modified
BIN
+724 Bytes
(100%)
...afari/DBSection-should-match-screenshot-1/DBSection-should-match-screenshot.png
Oops, something went wrong.
Binary file modified
BIN
+606 Bytes
(100%)
...ebkit/DBSection-should-match-screenshot-1/DBSection-should-match-screenshot.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# DEV Research multi-select | ||
|
||
## Overview | ||
|
||
| Design System | Component | Comment | | ||
| --------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------------------------------------------------: | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | ||
| [Atlassian Design System](https://bitbucket.org/atlassian/atlaskit/src/master/) | [multi-select](https://atlassian.design/components/select/examples#multi-select) | tags with divs + `input` (no filter) with `aria-autocomplete="list"` `aria-expanded="false"` `aria-haspopup="true"` `role="combobox"` + creates dropdown in dom on click | | ||
| [Bootstrap](https://github.com/twbs/bootstrap) | ❌ | -- | | ||
| [GitHub Primer](https://github.com/primer/css) | [selectpanel](https://primer.style/components/selectpanel/react/alpha) | tags inside button as `span` + button with `aria-expanded="false"` + extra container with filter input and checkbox group | | ||
| [GitLab Pajamas](https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com) | [dropdown-combobox](https://design.gitlab.com/components/dropdown-combobox) | tags inside button as `span` + `button` with `aria-haspopup="listbox"` + extra container with filter input and list buttons | | ||
| [HP Enterprise Grommet](https://github.com/grommet/grommet) | [selectmultiple](https://v2.grommet.io/selectmultiple) | tags inside input as `text` + input + extra container with filter input and checkbox group | | ||
| [IBM Carbon](https://github.com/carbon-design-system/carbon) | [multi-select](https://react.carbondesignsystem.com/?path=/docs/components-multiselect--overview) | tags with remove button + `button` or `input` with `aria-haspopup="listbox"` + extra container checkbox group | | ||
| [Material UI](https://github.com/mui/material-ui) | [Combobox](https://mui.com/material-ui/react-autocomplete/) | tags with remove button + `input` with `aria-expanded` &`role=combobox` + extra container list buttons | | ||
| [MongoDB.design](https://github.com/mongodb/design) | [combobox](https://www.mongodb.design/component/combobox/live-example) | tags with remove button (tabable) + `input` with `aria-expanded` &`role=combobox` + extra container checkbox group | | ||
| [Porsche Design System](https://github.com/porsche-design-system/porsche-design-system) | [multi-select](https://designsystem.porsche.com/v3/components/multi-select/examples) | tags inside input as `text` + input with filter + extra container and checkbox group | | ||
| [SBB Lyne](https://github.com/lyne-design-system/lyne-components) | [multi-select](https://lyne-storybook.app.sbb.ch/?path=/story/elements-sbb-select--multiple-select) | only divs + extra container and checkbox group | | ||
| [Shopify Polaris](https://github.com/Shopify/polaris) | [combobox](https://polaris.shopify.com/components/selection-and-input/combobox?example=combobox-with-multi-select-and-vertical-content) | ags with remove button (tabable) + `input` with `aria-expanded` &`role=combobox` + extra container checkbox group | | ||
| [SNCF Design System](https://gitlab.com/SNCF/wcs) | [multi-select](https://designmetier-bootstrap.sncf.fr/docs/4.3/components/select/#multiple) | sr-only `select` + extra container with list buttons | | ||
| [Telefonica Mistica](https://github.com/Telefonica/mistica-web) | ❌ | -- | | ||
| [Telekom Scale](https://github.com/telekom/scale) | ❌ | -- | | ||
| [Washington Post Design System](https://build.washingtonpost.com/) | ❌ | -- | | ||
|
||
## Conclusion | ||
|
||
- Often named [Combobox](https://component.gallery/components/combobox/) or Autocomplete or Autosuggest | ||
- [combobox_role](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/combobox_role) | ||
- [combobox example w3](https://www.w3.org/WAI/ARIA/apg/patterns/combobox/) | ||
|
||
We should work with the button + checkbox approach. Maybe we can replace `button` with `details` + `summary`. Furthermore, out filtering (search inout) will be inside the dropdown/menu (see design). We may use `DBSelectOptionType` for the checkboxes to reflect groups etc. | ||
Tags should be our `DBTag` with close function or a `span` based on the props we should change it like this variant="tags|overflow|amount". |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.