Skip to content

Commit

Permalink
[simple-v-table] Remove default header-label
Browse files Browse the repository at this point in the history
Fixes #340
  • Loading branch information
kimo-k committed May 14, 2024
1 parent 40b0a8c commit 9b4522e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

> Committed but unreleased changes are put here, at the top. Older releases are detailed chronologically below.
## 2.21.4 (2024-05-14)

#### Fixed

- `simple-v-table` - Removed default header-labels, since they show up badly in existing apps. (#340)


## 2.21.3 (2024-05-09)

Expand Down
3 changes: 1 addition & 2 deletions src/re_com/simple_v_table.cljs
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@
[& _]
(fn [{:keys [parts sort-by-column hover? column-header-height]
{:keys [id row-label-fn width height align header-label sort-by]} :column}]
(let [header-label (or header-label (name id))
sort-by (cond (true? sort-by) {} :else sort-by)
(let [sort-by (cond (true? sort-by) {} :else sort-by)
default-sort-by {:key-fn row-label-fn :comp compare :id id :order :asc}
ps (position-for-id id @sort-by-column)
{current-order :order} (item-for-id id @sort-by-column)
Expand Down

0 comments on commit 9b4522e

Please sign in to comment.