Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #359 (comment)
Changes:
GifExportParams
to tell users that different vips version will use different paramsStripMetadata
is removed aslibvips
does not support this function on GIFs, I've tried pass it in withVIPS_OBJECT(operation), "strip", params->stripMetadata,
, the output image remains the same.bitdepth
in early vips versionHowever this PR is not finished, I've found several problems here.
Dither
,Effort
orBitdepth
, the output image's sha256sum remains the sameset_gifsave_options
, only one parameter can be used with passed in multiple parameters, as belowBut, as different parameters will result in same output image, I'm not sure why this is happening.