Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cr/fix pipeline #111

Merged
merged 4 commits into from
Jun 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
python-version: [3.6]
python-version: [3.7, 3.8]

steps:
# Checkout the code from the repo
Expand All @@ -26,7 +26,7 @@ jobs:
- name: Install Poetry
uses: snok/install-poetry@v1
with:
version: 1.1.6
version: 1.5.1
virtualenvs-create: true
virtualenvs-in-project: true
installer-parallel: true
Expand Down
16 changes: 13 additions & 3 deletions gns3fy/gns3fy.py
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ def create(self):
data = {
k: v
for k, v in self.__dict__.items()
if k not in ("connector", "__initialised__","__pydantic_initialised__")
if k not in ("connector", "__initialised__", "__pydantic_initialised__")
if v is not None
}

Expand Down Expand Up @@ -1258,7 +1258,15 @@ def create(self):
data = {
k: v
for k, v in self.__dict__.items()
if k not in ("stats", "nodes", "links", "connector", "__initialised__","__pydantic_initialised__")
if k
not in (
"stats",
"nodes",
"links",
"connector",
"__initialised__",
"__pydantic_initialised__",
)
if v is not None
}

Expand Down Expand Up @@ -1872,7 +1880,9 @@ def delete_link(self, node_a, port_a, node_b, port_b):
):
_matches.append(_l)
if not _matches:
raise ValueError(f"Link not found: {node_a, port_a, node_b, port_b}") # pragma: no cover
raise ValueError(
f"Link not found: {node_a, port_a, node_b, port_b}"
) # pragma: no cover

# now to delete the link via GNS3_api
_link = _matches[0]
Expand Down
Loading