-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional Project properties #21
base: develop
Are you sure you want to change the base?
Conversation
Fixing some ref
Adding gns3_nodes_inventory and bumping gns3fy usage to 0.3.0
bumping to 1.2.1
Updating to gns3fy 0.4.0
Bumping to v1.2.2
Bumping to version 1.3.0
Adding gns3_node
Bumping to 1.5.0
Add support for specifying project_path, used only if project_name is specified. My assumption is if one is using project_id then human friendly names and paths are not a big concern.
This seems pretty cool, do you have an example screenshot of a lab with these settings turned on? |
Created with a play containing: My use case for the path is having a central GNS3 server as a Lab environment for multiple trainees and using their username to differentiate who each project belongs to on the assumption they will all do the same set of labs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, just a small typo but should be good to go
plugins/modules/gns3_project.py
Outdated
@@ -51,6 +51,18 @@ | |||
description: | |||
- Project name | |||
type: str | |||
project_path: | |||
description: | |||
- Project path (Ignore in name not specified) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be "Ignore if name not specified"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or better yet, something like "(Optional) Path of the project on the server"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about : Path of the project on the server ( Optional, Ignored if project_name not specified )
Additional project properties for scene_height, scene_width and project_path.
project_path is only used if Project name is also specified as it make no sense to put a friendly path on a project identified by a GUID
if no value for scene_height and scene_width is specified they are set null so the GNS3 defaults are respected