Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Project properties #21

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

Domoninic
Copy link

Additional project properties for scene_height, scene_width and project_path.
project_path is only used if Project name is also specified as it make no sense to put a friendly path on a project identified by a GUID
if no value for scene_height and scene_width is specified they are set null so the GNS3 defaults are respected

davidban77 and others added 12 commits August 28, 2019 17:47
Adding gns3_nodes_inventory and bumping gns3fy usage to 0.3.0
Add support for specifying project_path, used only if project_name is specified.
My assumption is if one is using project_id then human friendly names and paths are not a big concern.
@Domoninic Domoninic changed the base branch from master to develop September 10, 2023 19:43
@Domoninic Domoninic changed the title Project properties Additional Project properties Sep 10, 2023
@Domoninic Domoninic closed this Sep 10, 2023
@Domoninic Domoninic deleted the Project-Properties branch September 10, 2023 20:18
@Domoninic Domoninic restored the Project-Properties branch September 10, 2023 20:22
@Domoninic Domoninic reopened this Sep 10, 2023
@davidban77
Copy link
Owner

This seems pretty cool, do you have an example screenshot of a lab with these settings turned on?

@Domoninic
Copy link
Author

This seems pretty cool, do you have an example screenshot of a lab with these settings turned on?

Sure:
Project Path
Project Settings

Created with a play containing:
project_name: "{{ project_name }}"
project_path: "{{ projects_path }}{{ project_name }}"
scene_height: 550
scene_width: 550
where the vars contain :
project_name: "GNS3fy_Ansible"
projects_path: "/opt/gns3/projects/"

My use case for the path is having a central GNS3 server as a Lab environment for multiple trainees and using their username to differentiate who each project belongs to on the assumption they will all do the same set of labs.

Copy link
Owner

@davidban77 davidban77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just a small typo but should be good to go

@@ -51,6 +51,18 @@
description:
- Project name
type: str
project_path:
description:
- Project path (Ignore in name not specified)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "Ignore if name not specified"?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or better yet, something like "(Optional) Path of the project on the server"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about : Path of the project on the server ( Optional, Ignored if project_name not specified )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants