-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom canvas #85
Zoom canvas #85
Conversation
Pull Request Test Coverage Report for Build 10841705424Details
💛 - Coveralls |
demo/src/SvgDisplay.tsx
Outdated
width={canvasWidth} | ||
height={canvasHeight} | ||
/> | ||
<div style={{ height: 500, justifyContent: "center" }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally convinced you need a div
here, but if you want to keep it you should make its width
style 100%
to ensure it fills its parent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoonieaj good job. I left one more comment, and also don't forget to fill out the checklist.
Nice work, @yoonieaj! |
Proposed Changes
This pull request adds zoom capabilities to the output canvas using the react-pinch-pan-zoom library. This feature will improve ease of use of the website.
...
current output (zoomed out):
Screenshots
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
Hi Professor, currently there are small margins on the left/right edges of the output box (I included a screenshot below). I couldn't figure out how to get rid of them - changing component widths didn't seem to work. Do you have any suggestions on next steps I can try?