Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left margin bug #51

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

yoonieaj
Copy link
Collaborator

@yoonieaj yoonieaj commented Jul 3, 2024

Proposed Changes

This pull request fixes an issue where generating diagrams with large left margins resulted in object boxes being drawn on top of the call stack. Now, objects boxes will always be drawn to the right of the call stack (by a distance equal to the padding set by the user), as expected.
...

Screenshots of your changes (if applicable)

Before:

Screenshot 2024-07-03 160117

After:

Screenshot 2024-07-03 160129

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9784331647

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.925%

Totals Coverage Status
Change from base Build 9731797619: 0.2%
Covered Lines: 407
Relevant Lines: 438

💛 - Coveralls

@yoonieaj yoonieaj requested a review from david-yz-liu July 8, 2024 04:27
CHANGELOG.md Outdated
@@ -39,6 +39,7 @@ and adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
- Removed double quotes when rendering objects of type `None`.
- Removed double quotes when rendering objects that are not of type `str`.
- Fixed issue where diagrams would not render when width inputs to `draw()` were too small.
- Fixed issue where object boxes would be drawn on top of stack frames in diagrams with large left margins.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to the new unreleased section.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9848228885

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 89.925%

Totals Coverage Status
Change from base Build 9731797619: 0.2%
Covered Lines: 407
Relevant Lines: 438

💛 - Coveralls

@yoonieaj yoonieaj requested a review from david-yz-liu July 9, 2024 02:45
@david-yz-liu david-yz-liu merged commit b340931 into david-yz-liu:master Jul 9, 2024
3 checks passed
@yoonieaj yoonieaj deleted the left-margin-bug branch September 17, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants