Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --roughjs_config option for MemoryViz CLI #48

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

sarahsonder
Copy link
Collaborator

@sarahsonder sarahsonder commented Jun 27, 2024

Proposed Changes

This pull requests adds the option to configure the options parameter of the draw function.

Sample call: memory-viz <path-to-file> --roughjs-config bowing=3,fill=red,fillStyle=solid

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9689140202

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9647373036: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

@sarahsonder sarahsonder requested a review from david-yz-liu June 27, 2024 01:50
@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9689383321

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9647373036: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

docs/docs/06-cli.md Outdated Show resolved Hide resolved
memory-viz/bin/cli.js Outdated Show resolved Hide resolved
memory-viz/bin/cli.js Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9706609970

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9647373036: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

@sarahsonder sarahsonder requested a review from david-yz-liu June 28, 2024 02:43
@david-yz-liu david-yz-liu merged commit 701a7fc into david-yz-liu:master Jun 28, 2024
3 checks passed
@sarahsonder sarahsonder deleted the cli-add-roughjs-config branch June 29, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants