Commander cli #47
Merged
Commander cli #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9608043343Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9636137265Details
💛 - Coveralls |
memory-viz/src/tests/cli.spec.tsx
Outdated
| it("produces consistent svg when provided height and width options", (done) => { | ||
| fs.writeFileSync(filePath, input); | ||
|
|
||
| exec(`memory-viz ${filePath} --height=700, width=1200`, (err) => { |
There was a problem hiding this comment.
There shouldn't be a comma after the 700
package.json
Outdated
| @@ -17,5 +17,8 @@ | |||
| }, | |||
| "lint-staged": { | |||
| "**/*": "prettier --write --ignore-unknown" | |||
| }, | |||
| "dependencies": { | |||
There was a problem hiding this comment.
This isn't the right place to add this; you need to add it to the memory-viz/ subpackage.
I actually realized that this is also true for the tmp dev dependency for testing. Please go ahead and fix that in this PR (i.e., remove tmp from the dev dependency list above and move it to the memory-viz/ subpackage.
Pull Request Test Coverage Report for Build 9640526770Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9647281387Details
💛 - Coveralls |
david-yz-liu
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adopted
Commander.jslibrary for the MemoryViz CLI, and added optional--widthand--heightarguments to specify the width and height of SVGs generated with the CLI. This simplifies the CLI code and adds functionality....
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)