Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix.ci to CI workflow #46

Merged
merged 11 commits into from
Jun 24, 2024

Conversation

sarahsonder
Copy link
Collaborator

@sarahsonder sarahsonder commented Jun 19, 2024

Proposed Changes

This pull request replaces the stefanzweifel/git-auto-commit-action@v4 workflow with autofix.ci. Now, if for some reason prettier is not applied when committing code, autofix.ci will add a new commit with the proper formatting (as seen in the commit history below).

Note: the reason why I added a new .yml file is because the workflow in which autofix.ci is called must be named "autofix.ci".

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

Currently autofix cannot change files in the .github directory. I am assuming this is for security reasons - is that ok?

@sarahsonder sarahsonder marked this pull request as ready for review June 19, 2024 20:31
@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9587845328

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9587904329

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

@sarahsonder sarahsonder changed the title test autofix.ci Add autofix.ci to CI workflow Jun 19, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 19, 2024

Pull Request Test Coverage Report for Build 9587948657

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

@sarahsonder sarahsonder requested a review from david-yz-liu June 19, 2024 20:53
.github/workflows/autofix-ci.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
memory-viz/src/tests/test_autofix.js Outdated Show resolved Hide resolved
@sarahsonder sarahsonder requested a review from david-yz-liu June 20, 2024 15:19
@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9600016147

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.692%

Totals Coverage Status
Change from base Build 9574231615: 0.0%
Covered Lines: 388
Relevant Lines: 429

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 5580f67 into david-yz-liu:master Jun 24, 2024
3 checks passed
@sarahsonder sarahsonder deleted the add-autofix branch June 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants