-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory viz cli #43
Memory viz cli #43
Conversation
@sarahsonder good questions.
|
This comment was marked as outdated.
This comment was marked as outdated.
@sarahsonder don't put the pull request template in a comment. Instead edit the pull request description so that it contains the full information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarahsonder good work. Regarding the failing tests, there's an error in how the module is being imported (and likely your local environment is different from GitHub Actions).
Try using a different approach:
- Modify the GitHub Actions workflow to first run the webpack build command before running the tests
- (perhaps try this, not sure) In the test cases, invoke just
memory-viz
rather thannpx memory-viz
Pull Request Test Coverage Report for Build 9558806459Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9572882702Details
💛 - Coveralls |
Proposed Changes
The purpose of this pull request is to create a command line interface for MemoryViz. This is to make it easier to run MemoryViz.
To run the CLI, run
npm i
to install the CLI and then runmemory-viz <file-to-path>
, replacing<path-to-file>
with the path to a file containing MemoryViz-compatible JSONType of Change
Checklist
Before opening your pull request:
After opening your pull request:
Questions and Comments