Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double quotes when rendering objects of type None #42

Merged

Conversation

sarahsonder
Copy link
Collaborator

@sarahsonder sarahsonder commented Jun 6, 2024

Proposed Changes

The purpose of this PR is to change the rendering of objects of type None. Previously, the value would display as "None", and now it is displayed as None without the double quotes (screenshots included below!). This is to reflect the actual value of None in memory.

Screenshots of your changes

For the input { "type": "None", "id": 13, "value": "None" }, the first image is the previous output and the second image is the current output.

image

image

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

@sarahsonder sarahsonder requested a review from david-yz-liu June 6, 2024 23:09
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9408998315

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 86.883%

Totals Coverage Status
Change from base Build 9376313216: 0.08%
Covered Lines: 383
Relevant Lines: 426

💛 - Coveralls

@david-yz-liu david-yz-liu merged commit 5253853 into david-yz-liu:master Jun 7, 2024
3 checks passed
@sarahsonder sarahsonder deleted the fix-rendering-of-None branch June 7, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants