-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations #41
Merged
Merged
Type annotations #41
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ae40d37
add type annotations and interfaces
yoonieaj 4c1bdd1
Merge branch 'master' of https://github.com/david-yz-liu/memory-viz i…
yoonieaj e0e05cb
Make relevant attributes optional and update automate.ts to properly …
yoonieaj 4ad4b47
Move type interfaces into a new file
yoonieaj 8415a58
Make show_indexes and style attributes optional
yoonieaj 403cc5c
Update changelog
yoonieaj e4a3562
Merge branch 'master' into type-annotations
yoonieaj 6fbea06
Merge branch 'type-annotations' of https://github.com/yoonieaj/memory…
yoonieaj 1f3ee04
Rename DrawnObject to DrawnEntity and fix imports/exports
yoonieaj a17f872
Add DrawnEntity type annotation to source code files
yoonieaj d6be266
Merge branch 'master' of https://github.com/david-yz-liu/memory-viz i…
yoonieaj 8e08aad
Remove isClass and stack_frame attributes from DrawnEntity
yoonieaj bd91cdd
Add type annotations to source files
yoonieaj 07846c7
Update changelog
yoonieaj fef988a
Make new DrawnEntity attributes optional and fix annotation in types.ts
yoonieaj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
export interface DrawnEntity { | ||
name?: string; | ||
type?: string; | ||
x?: number; | ||
y?: number; | ||
id: number | string; | ||
value: any; | ||
show_indexes?: boolean; | ||
style?: Style; | ||
height: number; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this, |
||
width: number; | ||
rowBreaker: boolean; | ||
} | ||
|
||
export interface AttributeStyle { | ||
[propName: string]: string | number; | ||
} | ||
|
||
export interface Style { | ||
text_id?: AttributeStyle; | ||
text_type?: AttributeStyle; | ||
text_value?: AttributeStyle; | ||
box_id?: AttributeStyle; | ||
box_type?: AttributeStyle; | ||
box_container?: AttributeStyle; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to be
DrawnEntity
?