-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed isClass and stack_frame as types #40
Merged
david-yz-liu
merged 9 commits into
david-yz-liu:master
from
sarahsonder:turn-isClass-and-stackframe-to-types
Jun 7, 2024
Merged
Embed isClass and stack_frame as types #40
david-yz-liu
merged 9 commits into
david-yz-liu:master
from
sarahsonder:turn-isClass-and-stackframe-to-types
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9408747160Details
💛 - Coveralls |
sarahsonder
changed the title
Turn is class and stackframe to types
Turn isClass and stack_frame into types
Jun 4, 2024
sarahsonder
changed the title
Turn isClass and stack_frame into types
Embed isClass and stack_frame as types
Jun 4, 2024
david-yz-liu
reviewed
Jun 4, 2024
…nto turn-isClass-and-stackframe-to-types
sarahsonder
requested review from
david-yz-liu
and removed request for
david-yz-liu
June 5, 2024 19:54
david-yz-liu
reviewed
Jun 5, 2024
david-yz-liu
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR removes the
isClass
andstack_frame
attributes and embeds them as the types.class
and.frame
. In addition, the input for the blank type has been changed fromBLANK
to.blank
, and blank stack frames are now denoted by the type.blank-frame
. These changes serve to streamline the process of drawing objects, classes, and stack frames while also reducing the complexity of the user input.Type of Change
Checklist
Before opening your pull request:
After opening your pull request: