Highlight box bug

[yoonieaj]

Proposed Changes

Fixed a bug where the fill colour of boxes covered and hid the text in the box. This was done by changing the order in which elements are drawn.
Also changed the implementation of the hide style option. Now, this option sets text opacity to zero (before, it covered the text with a white box), so that the hide style option still works after the above bug fix.

...

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type	Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)	X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

• I have performed a self-review of my changes.
  • Check that all changed files included in this pull request are intentional changes.
  • Check that all changes are relevant to the purpose of this pull request, as described above.
• I have added tests for my changes, if applicable.
  • This is required for all bug fixes and new features.
• I have updated the project documentation, if applicable.
  • This is required for new features.
• If this is my first contribution, I have added myself to the list of contributors.
• I have updated the project Changelog (this is required for all changes).

After opening your pull request:

• I have verified that the CI tests have passed.
• I have reviewed the test coverage changes reported by Coveralls.
• I have requested a review from a project maintainer.

Questions and Comments

I went over the snapshots and it seems like they were failing because of the changed order in which elements were drawn, so I decided to update the snapshots and have included the updated versions in this PR.

[coveralls]

Pull Request Test Coverage Report for Build 9370168024

Details

• 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 86.801%

---

Totals
Change from base Build 9327208107:	0.02%
Covered Lines:	381
Relevant Lines:	424

---

💛 - Coveralls

[david-yz-liu]

@yoonieaj good job. You fixed the immediate bug, but should look for all places where drawText is called, and make sure it's called after the corresponding drawRect calls. Otherwise this issue might come up again later.

[david-yz-liu]

This change a bug fix, so should go under the "Bug fixes" section. You should describe in more detail what the bug is, but don't need to mention specific implementation details. I.e., focus on the what, not the how.