Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw function test cases (data types and manual layout) #30

Merged

Conversation

sarahsonder
Copy link
Collaborator

@sarahsonder sarahsonder commented May 16, 2024

Proposed Changes

Added tests for the draw function, covering data types and manual layouts.

Previously, there was only one general snapshot test. The purpose of this PR is to write tests that check for more specific behaviours.

Type of Change

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

Yoonie will be covering automatic layouts and custom styling!

@coveralls
Copy link
Collaborator

coveralls commented May 16, 2024

Pull Request Test Coverage Report for Build 9164741035

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+25.4%) to 84.759%

Totals Coverage Status
Change from base Build 9164734129: 25.4%
Covered Lines: 376
Relevant Lines: 423

💛 - Coveralls

@sarahsonder sarahsonder requested a review from david-yz-liu May 16, 2024 17:12
Copy link
Owner

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarahsonder great work! In addition to the inline comments I left, please add test cases for empty collections (list/tuple/set/dict).

memory-viz/src/tests/draw.spec.tsx Show resolved Hide resolved
memory-viz/src/tests/draw.spec.tsx Show resolved Hide resolved
@sarahsonder sarahsonder requested a review from david-yz-liu May 20, 2024 18:15
@david-yz-liu david-yz-liu merged commit 8a2b37d into david-yz-liu:master May 20, 2024
3 checks passed
@sarahsonder sarahsonder deleted the draw-function-test-cases branch May 21, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants