-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch mode #107
Batch mode #107
Conversation
memory-viz/src/user_functions.ts
Outdated
function getCanvasDimensions( | ||
configuration: Partial<DisplaySettings>, | ||
snapshotObjects: DrawnEntity[] | ||
): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-yz-liu I extracted this code for getting the canvas dimension in the manual mode. I was wondering if it would be better to move it into MemoryModel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm yes, I think it's better to move into MemoryModel
. Good suggestion
Pull Request Test Coverage Report for Build 12098050130Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leowrites thank you!
Proposed Changes
This PR adds a batch mode to the MemoryViz API. Users can now input multiple snapshots to be drawn, and each snapshot will have its own MemoryModel instance.
Type of Change
(Write an
X
or a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]
into a[x]
in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)