Convert modal to dialog

david-yz-liu · Oct 3, 2024 · aeef171 · aeef171
1 parent d6386d3
commit aeef171
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 40 deletions.
diff --git a/demo/src/MemoryModelsUserInput.tsx b/demo/src/MemoryModelsUserInput.tsx
@@ -11,6 +11,9 @@ import {
     Stack,
     Modal,
     Paper,
+    Dialog,
+    DialogActions,
+    DialogContent,
 } from "@mui/material";
 import DownloadJSONButton from "./DownloadJSONButton";
 import MemoryModelsMenu from "./MemoryModelsMenu";
@@ -79,46 +82,36 @@ function MemoryModelsFileInput(props: MemoryModelsFileInputPropTypes) {
             <Button onClick={handleOpen} sx={{ textTransform: "none" }}>
                 Upload JSON File
             </Button>
-            <Modal
+            <Dialog
                 open={open}
                 onClose={handleClose}
-                data-testid="file-input-modal"
+                data-testid="file-input-dialog"
             >
-                <Paper
-                    sx={{
-                        position: "absolute",
-                        top: "40%",
-                        left: "20%",
-                        width: "50%",
-                        padding: 2,
-                    }}
-                >
-                    <div>
-                        <Input
-                            type="file"
-                            onChange={onChange}
-                            inputProps={{
-                                accept: "application/JSON",
-                                "data-testid": "file-input",
-                            }}
-                            disableUnderline={true}
-                            sx={{ alignSelf: "center" }}
-                        />
-                    </div>
-                    <div>
-                        <Button
-                            data-testid="file-input-reapply-button"
-                            variant="contained"
-                            color="primary"
-                            disabled={!uploadedFileString}
-                            onClick={onLoadButtonClick}
-                            sx={{ textTransform: "none" }}
-                        >
-                            Load file data
-                        </Button>
-                    </div>
-                </Paper>
-            </Modal>
+                <DialogContent>
+                    <Input
+                        type="file"
+                        onChange={onChange}
+                        inputProps={{
+                            accept: "application/JSON",
+                            "data-testid": "file-input",
+                        }}
+                        disableUnderline={true}
+                        sx={{ alignSelf: "center" }}
+                    />
+                </DialogContent>
+                <DialogActions>
+                    <Button
+                        data-testid="file-input-reapply-button"
+                        variant="contained"
+                        color="primary"
+                        disabled={!uploadedFileString}
+                        onClick={onLoadButtonClick}
+                        sx={{ textTransform: "none" }}
+                    >
+                        Load file data
+                    </Button>
+                </DialogActions>
+            </Dialog>
         </div>
     );
 }

diff --git a/demo/src/__tests__/MemoryModelsUserInput.spec.tsx b/demo/src/__tests__/MemoryModelsUserInput.spec.tsx
@@ -133,9 +133,9 @@ describe("MemoryModelsUserInput", () => {
             jest.restoreAllMocks();
         });
 
-        it("does not render the modal when the page first loads", () => {
-            const modal = screen.queryByTestId("file-input-modal");
-            expect(modal).toBeNull();
+        it("does not render the dialog when the page first loads", () => {
+            const dialog = screen.queryByTestId("file-input-dialog");
+            expect(dialog).toBeNull();
 
             const input: HTMLInputElement = screen.queryByTestId("file-input");
             expect(input).toBeNull();