Skip to content

Commit

Permalink
incorporate reviews round 2
Browse files Browse the repository at this point in the history
  • Loading branch information
sarahsonder committed Jun 18, 2024
1 parent bb32f3f commit 41514f1
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 14 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ jobs:
cache: npm
- name: Install npm packages
run: npm ci
- name: Compile JavaScript assets
run: npm run build --workspace=memory-viz
- name: Run jest tests
run: |
npm run build --workspace=memory-viz
npm run test-cov
run: npm run test-cov
- name: Coveralls (jest)
uses: coverallsapp/github-action@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/06-cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ To run the MemoryViz CLI, run:
$ npx memory-viz <path-to-file>
```

replacing `<path-to-file>` with the path to a file containing MemoryViz-compatible JSON. If the file extension is not `.json` or if the file content is not compatible with MemoryViz, an error will be thrown.
replacing `<path-to-file>` with the path to a file containing MemoryViz-compatible JSON. If the file content is not compatible with MemoryViz, an error will be thrown.

## Output

Expand Down
2 changes: 1 addition & 1 deletion memory-viz/bin/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ let data;
try {
data = JSON.parse(fileContent);
} catch (err) {
console.error(`Error: Invalid JSON.`);
console.error(`Error: Invalid JSON\n${err.message}.`);
process.exit(1);
}

Expand Down
2 changes: 1 addition & 1 deletion memory-viz/src/tests/cli.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe.each([
},
{
errorType: "invalid json",
expectedErrorMessage: "Error: Invalid JSON.",
expectedErrorMessage: "Error: Invalid JSON",
},
{
errorType: "invalid memory-viz json",
Expand Down
7 changes: 0 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"docs"
],
"devDependencies": {
"child_process": "^1.0.2",
"husky": "^8.0.3",
"lint-staged": "^14.0.1",
"prettier": "2.8.1",
Expand Down

0 comments on commit 41514f1

Please sign in to comment.