Merge pull request #41 from davewalker5/MC-256-Purchase-Retailer-Bug #293
davewalker5Annotations
11 warnings
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/setup-java@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
src/MusicCatalogue.Entities/Interfaces/IConfigReader.cs#L3
Add the 'out' keyword to parameter 'T' to make it 'covariant'.
|
|
build:
src/MusicCatalogue.Entities/Interfaces/IRetailerManager.cs#L8
Method has 10 parameters, which is greater than the 7 authorized.
|
|
build:
src/MusicCatalogue.Entities/Interfaces/IRetailerManager.cs#L22
Method has 11 parameters, which is greater than the 7 authorized.
|
|
build:
src/MusicCatalogue.Entities/Interfaces/IAlbumManager.cs#L8
Method has 9 parameters, which is greater than the 7 authorized.
|
|
build:
src/MusicCatalogue.Entities/Interfaces/IAlbumManager.cs#L19
Method has 10 parameters, which is greater than the 7 authorized.
|
|
build:
src/MusicCatalogue.Entities/DataExchange/FlattenedTrack.cs#L89
Use a format provider when parsing date and time.
|
|
build:
src/MusicCatalogue.Logic/Database/SearchManager.cs#L20
Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.
|
|
build:
src/MusicCatalogue.Logic/DataExchange/Catalogue/CatalogueXlsxExporter.cs#L60
Rename parameter 'recordCount' to 'recordNumber' to match the base class declaration.
|
|
build:
src/MusicCatalogue.Logic/DataExchange/Catalogue/CatalogueCsvExporter.cs#L47
Rename parameter '_' to 'recordNumber' to match the base class declaration.
|
|
build:
src/MusicCatalogue.Api/Program.cs#L24
Add a 'protected' constructor or the 'static' keyword to the class declaration.
|