Navigation refactor · davewalker5/MusicCatalogue@c8c8509

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/setup-java@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

src/MusicCatalogue.Logic/Database/JobStatusManager.cs#L78

Nullability of reference types in return type of 'Task<JobStatus?> JobStatusManager.UpdateAsync(long id, string error)' doesn't match implicitly implemented member 'Task<JobStatus> IJobStatusManager.UpdateAsync(long id, string error)'.

src/MusicCatalogue.Logic/Collection/AlbumLookupManager.cs#L82

Dereference of a possibly null reference.

src/MusicCatalogue.Logic/DataExchange/CsvImporter.cs#L50

Possible null reference argument for parameter 'name' in 'Task<Genre> IGenreManager.AddAsync(string name)'.

src/MusicCatalogue.Tests/AlbumLookupManagerTest.cs#L97

Dereference of a possibly null reference.

src/MusicCatalogue.Tests/AlbumLookupManagerTest.cs#L120

Dereference of a possibly null reference.

src/MusicCatalogue.Tests/AlbumManagerTest.cs#L59

Dereference of a possibly null reference.

src/MusicCatalogue.Tests/AlbumManagerTest.cs#L76

Dereference of a possibly null reference.

src/MusicCatalogue.Tests/AlbumLookupManagerTest.cs#L142

Dereference of a possibly null reference.

src/MusicCatalogue.Tests/AlbumManagerTest.cs#L119

Dereference of a possibly null reference.

src/MusicCatalogue.Tests/RetailerManagerTest.cs#L19

Cannot convert null literal to non-nullable reference type.

src/MusicCatalogue.Entities/Interfaces/IConfigReader.cs#L3

Add the 'out' keyword to parameter 'T' to make it 'covariant'.

src/MusicCatalogue.Entities/Interfaces/IAlbumManager.cs#L19

Method has 10 parameters, which is greater than the 7 authorized.

src/MusicCatalogue.Entities/Interfaces/IAlbumManager.cs#L8

Method has 9 parameters, which is greater than the 7 authorized.

src/MusicCatalogue.Entities/DataExchange/FlattenedTrack.cs#L89

Use a format provider when parsing date and time.

src/MusicCatalogue.Logic/Database/JobStatusManager.cs#L78

Nullability of reference types in return type of 'Task<JobStatus?> JobStatusManager.UpdateAsync(long id, string error)' doesn't match implicitly implemented member 'Task<JobStatus> IJobStatusManager.UpdateAsync(long id, string error)'.

src/MusicCatalogue.Logic/Collection/AlbumLookupManager.cs#L82

Dereference of a possibly null reference.

src/MusicCatalogue.Logic/DataExchange/CsvImporter.cs#L50

Possible null reference argument for parameter 'name' in 'Task<Genre> IGenreManager.AddAsync(string name)'.

src/MusicCatalogue.Logic/DataExchange/CsvExporter.cs#L47

Rename parameter '_' to 'recordNumber' to match the base class declaration.

src/MusicCatalogue.Logic/DataExchange/XlsxExporter.cs#L60

Rename parameter 'recordCount' to 'recordNumber' to match the base class declaration.

src/MusicCatalogue.Api/Services/BackgroundQueueProcessor.cs#L56

Dereference of a possibly null reference.