Skip to content

Merge pull request #25 from davewalker5/MC-143-Genres-Entity #204

Merge pull request #25 from davewalker5/MC-143-Genres-Entity

Merge pull request #25 from davewalker5/MC-143-Genres-Entity #204

Triggered via push November 15, 2023 17:44
Status Success
Total duration 1m 32s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/setup-java@v1, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build: src/MusicCatalogue.Logic/Collection/AlbumLookupManager.cs#L82
Dereference of a possibly null reference.
build: src/MusicCatalogue.Logic/Database/ArtistManager.cs#L94
Dereference of a possibly null reference.
build: src/MusicCatalogue.Logic/DataExchange/CsvImporter.cs#L50
Possible null reference argument for parameter 'name' in 'Task<Genre> IGenreManager.AddAsync(string name)'.
build: src/MusicCatalogue.Logic/Database/JobStatusManager.cs#L92
Possible null reference return.
build: src/MusicCatalogue.Tests/AlbumManagerTest.cs#L59
Dereference of a possibly null reference.
build: src/MusicCatalogue.Tests/AlbumLookupManagerTest.cs#L97
Dereference of a possibly null reference.
build: src/MusicCatalogue.Tests/AlbumLookupManagerTest.cs#L120
Dereference of a possibly null reference.
build: src/MusicCatalogue.Tests/AlbumManagerTest.cs#L76
Dereference of a possibly null reference.
build: src/MusicCatalogue.Tests/DataExchangeTest.cs#L98
Dereference of a possibly null reference.
build: src/MusicCatalogue.Tests/AlbumLookupManagerTest.cs#L142
Dereference of a possibly null reference.
build: src/MusicCatalogue.Entities/Interfaces/IConfigReader.cs#L3
Add the 'out' keyword to parameter 'T' to make it 'covariant'.
build: src/MusicCatalogue.Entities/Interfaces/IAlbumManager.cs#L8
Method has 9 parameters, which is greater than the 7 authorized.
build: src/MusicCatalogue.Entities/Interfaces/IAlbumManager.cs#L19
Method has 10 parameters, which is greater than the 7 authorized.
build: src/MusicCatalogue.Entities/DataExchange/FlattenedTrack.cs#L89
Use a format provider when parsing date and time.
build: src/MusicCatalogue.Logic/DataExchange/CsvImporter.cs#L50
Possible null reference argument for parameter 'name' in 'Task<Genre> IGenreManager.AddAsync(string name)'.
build: src/MusicCatalogue.Logic/Database/JobStatusManager.cs#L92
Possible null reference return.
build: src/MusicCatalogue.Logic/Collection/AlbumLookupManager.cs#L82
Dereference of a possibly null reference.
build: src/MusicCatalogue.Logic/Database/ArtistManager.cs#L94
Dereference of a possibly null reference.
build: src/MusicCatalogue.Logic/DataExchange/CsvExporter.cs#L47
Rename parameter '_' to 'recordNumber' to match the base class declaration.
build: src/MusicCatalogue.Logic/DataExchange/XlsxExporter.cs#L60
Rename parameter 'recordCount' to 'recordNumber' to match the base class declaration.